Skip to content

Cppcheck suggested performance improvement #7

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
neuralsandwich wants to merge 1 commit into from
Closed

Cppcheck suggested performance improvement #7

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 5 additions & 5 deletions tiny_obj_loader.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -196,12 +196,12 @@ updateVertex(
static bool
exportFaceGroupToShape(
shape_t& shape,
const std::vector<float> in_positions,
const std::vector<float> in_normals,
const std::vector<float> in_texcoords,
const std::vector<float> &in_positions,
const std::vector<float> &in_normals,
const std::vector<float> &in_texcoords,
const std::vector<std::vector<vertex_index> >& faceGroup,
const material_t material,
const std::string name)
const material_t &material,
const std::string &name)
{
if (faceGroup.empty()) {
return false;
Expand Down